Skip to content

[fix] preRegister Device FingerPrinting 시도 횟수 중복 체크 코드 수정#345

Merged
thatgirls00 merged 2 commits into
mainfrom
fix/preRegister-device-fingerprinting-try
Jan 7, 2026
Merged

[fix] preRegister Device FingerPrinting 시도 횟수 중복 체크 코드 수정#345
thatgirls00 merged 2 commits into
mainfrom
fix/preRegister-device-fingerprinting-try

Conversation

@thatgirls00
Copy link
Copy Markdown
Collaborator

@thatgirls00 thatgirls00 commented Jan 7, 2026 •
edited
Loading

📌 개요

  • preRegister Device FingerPrinting 시도 횟수 중복 체크 코드 수정

✨ 작업 내용

  • 개요와 동일

🔗 관련 이슈

🧪 체크리스트

  • 코드에 오류 X
  • 테스트 코드 작성 / 통과 완료
  • 팀 내 코드 스타일 준수
  • 이슈 연결

@thatgirls00 thatgirls00 self-assigned this Jan 7, 2026
@thatgirls00 thatgirls00 added the 🔧 Fix 버그 또는 오류 수정 label Jan 7, 2026
@thatgirls00 thatgirls00 linked an issue Jan 7, 2026 that may be closed by this pull request
[fix] preRegister Device FingerPrinting 시도 횟수 중복 체크 코드 수정 #344
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 7, 2026 •
edited
Loading

Test Results

629 tests  ±0   623 ✅ ±0   47s ⏱️ +2s
165 suites ±0     6 💤 ±0 
165 files   ±0     0 ❌ ±0 

Results for commit abfac2a. ± Comparison against base commit 077c9b7.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ ErrorException 발생 시 visitorId로 실패 기록 (lines 140, 142)
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ ErrorException 발생 시 visitorId로 실패 기록 - 약관 미동의 (lines 140, 142)
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ 신규 등록 성공 시 visitorId로 성공 기록 (line 133)
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ 재등록 성공 시 visitorId로 성공 기록 (line 104)

com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ ErrorException 발생 시 Service에서 Fingerprint 기록하지 않음 (FingerprintRecordFilter에서 처리)
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ 신규 등록 성공 시 Service에서 Fingerprint 기록하지 않음 (FingerprintRecordFilter에서 처리)
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ 약관 미동의 시 Service에서 Fingerprint 기록하지 않음 (FingerprintRecordFilter에서 처리)
com.back.api.preregister.service.PreRegisterServiceTest$FingerprintRecording ‑ 재등록 성공 시 Service에서 Fingerprint 기록하지 않음 (FingerprintRecordFilter에서 처리)

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 7, 2026 •
edited
Loading

🧪 WaitFair Test Coverage

Line Coverage: 59.43%

📊 Coverage Details

Overall Line Coverage: 59.48% (1654 covered / 2781 lines)

Package Summary (lowest first)
Package Line % Covered Missed
com/back/api/payment/order/controller 0.00% 0 6
com/back/domain/seed/scenario/base 0.00% 0 52
com/back/api/s3/service 0.00% 0 37
com/back/global/services/sms/controller 0.00% 0 4
com/back/api/ticket/scheduler 0.00% 0 46
com/back/api/notification/controller 0.00% 0 13
com/back/api/seed/controller 0.00% 0 6
com/back/domain/seed/scenario 0.00% 0 34
com/back/api/s3/controller 0.00% 0 2
com/back/api/payment/payment/controller 0.00% 0 12
com/back/api/event/scheduler 0.00% 0 98
com/back/domain/seed/util 0.00% 0 9
com/back/global/security/util 0.00% 0 54
com/back/global/security/filter 0.00% 0 246
com/back/global/websocket/auth 5.00% 1 19
com/back/global/scheduler 8.33% 1 11
com/back/global/services/sms/util 9.52% 2 19
com/back/global/security/oauth 10.14% 7 62
com/back/global/websocket/session 21.05% 4 15
com/back/api/payment/payment/client 25.00% 1 3
com/back/api/store/service 25.00% 1 3
com/back/api/auth/store 40.91% 18 26
com/back/global/observability/metrics 50.00% 27 27
com/back/api/selection/service 50.00% 9 9
com/back/api/payment/order/service 52.24% 35 32
com/back/api/selection/controller 57.14% 4 3
com/back/api/ticket/controller 60.00% 6 4
com/back/global/observability 68.42% 39 18
com/back/api/payment/payment/service 68.48% 63 29
com/back/api/ticket/service 70.00% 70 30
com/back/global/http 70.65% 65 27
com/back/global/services/sms/service 75.41% 46 15
com/back/api/event/controller 79.17% 19 5
com/back/api/auth/service 79.69% 204 52
com/back/domain/notification/systemMessage 83.33% 35 7
com/back/global/security/service 83.51% 162 32
com/back/api/queue/controller 86.67% 13 2
com/back/global/utils 87.34% 69 10
com/back/api/seat/service 87.67% 128 18
com/back/global/security 88.20% 157 21
com/back/api/seat/controller 92.31% 24 2
com/back/global/hibernate 93.75% 15 1
com/back/api/event/service 97.35% 110 3
com/back/api/preregister/service 97.87% 92 2
com/back/api/user/service 98.04% 50 1
com/back/global/properties 100.00% 27 0
com/back/api/preregister/controller 100.00% 22 0
com/back/api/notification/service 100.00% 15 0
com/back/global/event 100.00% 2 0
com/back/api/user/controller 100.00% 9 0
com/back/api/notification/listener 100.00% 28 0
com/back/api/event/event 100.00% 4 0
com/back/api/auth/controller 100.00% 10 0
com/back/global/recaptcha/service 100.00% 31 0
com/back/api/seat/event 100.00% 13 0
com/back/domain/notification/enums 100.00% 16 0
Lowest Covered Classes (Top 20)
Class Line % Covered Missed
com.back.api.event.scheduler.EventScheduler 0.00% 0 98
com.back.global.security.filter.RateLimitFilter 0.00% 0 71
com.back.global.security.filter.FingerprintFilter 0.00% 0 69
com.back.global.security.filter.FingerprintRecordFilter 0.00% 0 58
com.back.domain.seed.scenario.base.BaseSeedScenario 0.00% 0 52
com.back.api.ticket.scheduler.DraftTicketExpirationScheduler 0.00% 0 46
com.back.global.security.service.RateLimitService 0.00% 0 30
com.back.global.security.filter.IdcBlockFilter 0.00% 0 29
com.back.global.security.util.ClientIpResolver 0.00% 0 28
com.back.api.s3.service.S3PresignedService 0.00% 0 24
com.back.api.auth.service.SocialAuthService 0.00% 0 20
com.back.domain.seed.scenario.SeedScenario2 0.00% 0 17
com.back.domain.seed.scenario.SeedScenario1 0.00% 0 17
com.back.global.security.util.CachedBodyHttpServletRequest 0.00% 0 17
com.back.global.security.filter.WhitelistFilter 0.00% 0 15
com.back.api.s3.service.S3MoveService 0.00% 0 13
com.back.api.notification.controller.NotificationController 0.00% 0 13
com.back.api.payment.payment.controller.PaymentController 0.00% 0 12
com.back.global.services.sms.util.SmsUtil 0.00% 0 11
com.back.domain.seed.util.SeedResetSupport 0.00% 0 9
Changed Classes (from this PR)
Source (PR) Class Prefix Line % Covered Missed
src/main/java/com/back/api/preregister/service/PreRegisterService.java com.back.api.preregister.service.PreRegisterService 97.73% 86 2

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_TxI_BE/actions/runs/20772680257

@thatgirls00 thatgirls00 merged commit f5e43c0 into main Jan 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeeMinwoo115 LeeMinwoo115 LeeMinwoo115 approved these changes

Assignees

@thatgirls00 thatgirls00

Labels

🔧 Fix 버그 또는 오류 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fix] preRegister Device FingerPrinting 시도 횟수 중복 체크 코드 수정

2 participants

@thatgirls00 @LeeMinwoo115